linux-kernel - RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001e01d944e7$e51c94d0$af55be70$@samsung.com>
Date:   Mon, 20 Feb 2023 13:57:55 +0900
From:   "Bumwoo Lee" <bw365.lee@...sung.com>
To:     <myungjoo.ham@...sung.com>,
        "'Chanwoo Choi'" <cw00.choi@...sung.com>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify
 extcon register function

I Got it.

I will prepare new patch for return value.

Thank for your comment.

Regards,
Bumwoo.
-----Original Message-----
From: MyungJoo Ham <myungjoo.ham@...sung.com> 
Sent: Monday, February 20, 2023 1:39 PM
To: Bumwoo Lee <bw365.lee@...sung.com>; Chanwoo Choi <cw00.choi@...sung.com>; linux-kernel@...r.kernel.org
Subject: RE: [PATCH 2/4] extcon: added extcon_alloc_cables to simplify extcon register function

>--------- Original Message ---------
>Sender : 이범우 <bw365.lee@...sung.com>Product S/W Lab(VD)/삼성전자 Date : 
>2023-02-17 17:48 (GMT+9) Title : [PATCH 2/4] extcon: added 
>extcon_alloc_cables to simplify extcon register function
> 
>The cable allocation part is functionalized from extcon_dev_register.
>
>Signed-off-by: Bumwoo Lee <bw365.lee@...sung.com>

...

>+        if (extcon_alloc_cables(edev))
>+                goto err_alloc_cables;
> 

You are abandoning error return values, here.
Please return appropriate error codes.

Cheers,
MyungJoo