linux-kernel - Re: [PATCH] genirq/msi: Take the per-device MSI lock before validating the control structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/PEac0U1uwRT3XG@shell.armlinux.org.uk>
Date:   Mon, 20 Feb 2023 19:05:13 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Marc Zyngier <maz@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        stable@...r.kernel.org
Subject: Re: [PATCH] genirq/msi: Take the per-device MSI lock before
 validating the control structure

On Mon, Feb 20, 2023 at 07:01:01PM +0000, Marc Zyngier wrote:
> Calling msi_ctrl_valid() ultimately results in calling
> msi_get_device_domain(), which requires holding the device MSI lock.
> 
> However, we take that lock right after having called msi_ctrl_valid(),
> which is just a tad too late. Taking the lock earlier solves the issue.
> 
> Fixes: 40742716f294 ("genirq/msi: Make msi_add_simple_msi_descs() device domain aware")
> Reported-by: "Russell King (Oracle)" <linux@...linux.org.uk>

Tested-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!