linux-kernel - Re: [PATCH 1/7] MIPS: Remove DMA_PERDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230221175628.GB15247@lst.de>
Date:   Tue, 21 Feb 2023 18:56:28 +0100
From:   Christoph Hellwig <hch@....de>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, tsbogend@...ha.franken.de,
        mpe@...erman.id.au, paul.walmsley@...ive.com, palmer@...belt.com,
        robh+dt@...nel.org, hch@....de, m.szyprowski@...sung.com,
        robin.murphy@....com
Subject: Re: [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT

On Tue, Feb 21, 2023 at 12:46:07PM +0000, Jiaxun Yang wrote:
> As now we are always managing DMA coherence on per dev bias,
> there is no need to have such option. And it's not selected
> by any platform.

I think the real point here is that this is dead code, so it can
obviously go away, but:

>  config MIPS_GENERIC_KERNEL
>  	bool "Generic board-agnostic MIPS kernel"
> -	select ARCH_HAS_SETUP_DMA_OPS
>  	select MIPS_GENERIC
>  	select BOOT_RAW
>  	select BUILTIN_DTB
> @@ -1079,11 +1078,6 @@ config FW_CFE
>  config ARCH_SUPPORTS_UPROBES
>  	bool

> @@ -1097,6 +1091,7 @@ config DMA_NONCOHERENT
>  	select ARCH_HAS_DMA_PREP_COHERENT
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>  	select ARCH_HAS_DMA_SET_UNCACHED
> +	select ARCH_HAS_SETUP_DMA_OPS

This is an unrelated und undocument change.  If you want to do it,
please do that as a separate patch with a commit log documenting
the rationale.