linux-kernel - Re: [PATCH 0/7] MIPS DMA coherence fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed2d7750-786d-82a1-5e79-1f216a682b20@arm.com>
Date:   Tue, 21 Feb 2023 19:46:08 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>,
        Christoph Hellwig <hch@....de>
Cc:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        mpe@...erman.id.au, paul.walmsley@...ive.com, palmer@...belt.com,
        Rob Herring <robh+dt@...nel.org>, m.szyprowski@...sung.com
Subject: Re: [PATCH 0/7] MIPS DMA coherence fixes

On 2023-02-21 18:15, Jiaxun Yang wrote:
> 
> 
>> 2023年2月21日 17:54，Christoph Hellwig <hch@....de> 写道：
>>
>> Can you explain the motivation here?  Also why riscv patches are at
>> the end of a mips fіxes series?
> 
> Ah sorry for any confusion.
> 
> So the main purpose of this patch is to fix MIPS’s broken per-device coherency.
> To be more precise, we want to be able to control the default coherency for all devices probed from
> devicetree in early boot code.

Including the patch which actually does that would be helpful. As it is, 
patches 4-7 here just appear to be moving an option around for no 
practical effect.

Robin.

> To achieve that I decided to reuse dma_default_coherent to set default coherency for devicetree.
> And all later patches are severing for this purpose.
> 
> Thanks
> - Jiaxun