linux-kernel - Re: [PATCH v2 15/16] thermal/drivers/acerhdf: Remove pointless governor test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2193efe-c001-a56b-8fd4-4485de6b185d@redhat.com>
Date:   Tue, 21 Feb 2023 21:07:56 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, rafael@...nel.org
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peter Kaestle <peter@...e.net>,
        Mark Gross <markgross@...nel.org>,
        "open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER" 
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 15/16] thermal/drivers/acerhdf: Remove pointless
 governor test

Hi,

On 2/21/23 19:07, Daniel Lezcano wrote:
> The thermal zone parameter specifies the bang-bang governor.
> 
> The Kconfig selects the bang-bang governor. So it is pointless to test
> if the governor was set for the thermal zone assuming it may not have
> been compiled-in.
> 
> Remove the test and prevent another access into the thermal internals.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Acked-by: Peter Kaestle <peter@...e.net>

Thanks, looks good to me, here is my ack for merging this through
the thermal tree.

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/platform/x86/acerhdf.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 61f1c3090867..71b9c1f922d9 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -697,13 +697,6 @@ static int __init acerhdf_register_thermal(void)
>  	if (ret)
>  		return ret;
>  
> -	if (strcmp(thz_dev->governor->name,
> -				acerhdf_zone_params.governor_name)) {
> -		pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n",
> -				acerhdf_zone_params.governor_name);
> -		return -EINVAL;
> -	}
> -
>  	return 0;
>  }
>