linux-kernel - Re: [PATCH] module: Remove the unused function within

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/U18FlTNVhwb6+q@bombadil.infradead.org>
Date:   Tue, 21 Feb 2023 13:21:52 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Song Liu <song@...nel.org>
Cc:     Chris Down <chris@...isdown.name>,
        Nathan Chancellor <nathan@...nel.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        ndesaulniers@...gle.com, trix@...hat.com,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, llvm@...ts.linux.dev,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] module: Remove the unused function within

On Wed, Feb 15, 2023 at 10:57:09AM -0800, Song Liu wrote:
> Hi Chris,
> 
> On Wed, Feb 15, 2023 at 9:23 AM Chris Down <chris@...isdown.name> wrote:
> >
> > +Cc: Song
> 
> Thanks for the CC!
> 
> >
> > Nathan Chancellor writes:
> > >On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
> > >> Jiapeng Chong writes:
> > >> > The function within is defined in the main.c file, but not called
> > >> > elsewhere, so remove this unused function.
> > >>
> > >> Huh? It's used by __module_text_address(), no?
> > >
> > >Not after commit 2ece476a2346 ("module: replace module_layout with
> > >module_memory") in -next. This patch should have a fixes tag, even if
> > >the warning is currently hidden behind W=1.
> >
> > Huh, I thought I had checked out latest -next, but must have not done so
> > somehow :-) Mea culpa.
> >
> > If it's only in -next then no Fixes needed, since there's no stable rev yet.
> >
> > Jiapeng, in future, please make sure to cc the author of related commits when
> > reporting stuff like this :-) It helps people to update their patches.
> >
> > Song, you probably want to update your patch.
> 
> Luis, would you prefer a new patch with everything folded in? Or would
> you apply the patches on your end?

I've merged this patch separately onto modules-next and enhanced the
commit log to explain its needed after your patch.

  Luis