linux-kernel - Re: [PATCH] module: fix MIPS module_layout -> module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/U6KrB6eR4aCmif@bombadil.infradead.org>
Date:   Tue, 21 Feb 2023 13:39:54 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Philippe Mathieu-Daudé <philmd@...aro.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, Song Liu <song@...nel.org>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory

On Fri, Feb 17, 2023 at 07:53:17AM -0800, Randy Dunlap wrote:
> 
> 
> On 2/17/23 04:35, Philippe Mathieu-Daudé wrote:
> > On 17/2/23 12:58, Thomas Bogendoerfer wrote:
> >> On Tue, Feb 14, 2023 at 08:52:04AM -0800, Randy Dunlap wrote:
> >>>
> >>>
> >>> On 2/13/23 23:22, Philippe Mathieu-Daudé wrote:
> >>>> Hi Randy,
> >>>>
> >>>> On 14/2/23 01:54, Randy Dunlap wrote:
> >>>>> Correct the struct's field/member name from mod_mem to mem.
> >>>>>
> >>>>> Fixes this build error:
> >>>>> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
> >>>>> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
> >>>>>     643 |         v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
> >>>>>
> >>>>> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
> >>>>
> >>>> On which tree is your patch based?
> >>>
> >>> linux-next-20230213.
> >>
> >> so I can't apply, because this is not in mips-next tree. It should be
> >> applied to the tree, where this commit is coming from.
> > 
> > Or squashed...
> > 
> 
> Sure, either one of those. I copied Song and Luis on the patch
> and it begins with "module:".
> 
> @Song !??
> @Luis !??

Thanks!

I've queued this up onto modules-next. That patch which changes the
layout won't go in on this merge window so it will all sit and bake
for a good long while before it gets upstream.

  Luis