linux-kernel - Re: [PATCH] net: phy: at803x: fix the wol setting functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/VMLF0NGgO1F34K@lunn.ch>
Date:   Tue, 21 Feb 2023 23:56:44 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Li Yang <leoyang.li@....com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Luo Jie <luoj@...eaurora.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Viorel Suman <viorel.suman@....com>,
        Wei Fang <wei.fang@....com>
Subject: Re: [PATCH] net: phy: at803x: fix the wol setting functions

On Tue, Feb 21, 2023 at 04:40:31PM -0600, Li Yang wrote:
> In 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it seems
> not correct to use a wol_en bit in a 1588 Control Register which is only
> available on AR8031/AR8033(share the same phy_id) to determine if WoL is
> enabled.  Change it back to use AT803X_INTR_ENABLE_WOL for determining
> the WoL status which is applicable on all chips supporting wol. Also
> update the at803x_set_wol() function to only update the 1588 register on
> chips having it.

> After this change, disabling wol at probe from
> d7cd5e06c9dd ("net: phy: at803x: disable WOL at probe") is no longer
> needed.  So it is removed.

Rather than remove it, please git revert it, and explain in the commit
message why.

> 
> Also remove the set_wol()/get_wol() callbacks from AR8032 which doesn't
> support WoL.

This change was part of 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")

Please break this patch up into individual fixes. The different fixes
might need different levels of backporting etc.

      Andrew