linux-kernel - [PATCH] vlynq: Fix a compilation with CONFIG_VLYNQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <TYZPR01MB4784D2F5E55D5DBE85150AD0D5A59@TYZPR01MB4784.apcprd01.prod.exchangelabs.com>
Date:   Tue, 21 Feb 2023 15:20:35 +0800
From:   tianyaxiong <iambestgod@...look.com>
To:     f.fainelli@...il.com
Cc:     linux-kernel@...r.kernel.org, trivial@...nel.org,
        tianyaxiong <tianyaxiong@...inos.cn>,
        k2ci <kernel-bot@...inos.cn>
Subject: [PATCH] vlynq: Fix a compilation with CONFIG_VLYNQ_DEBUG=y

From: tianyaxiong <tianyaxiong@...inos.cn>

  The vlynq_dump_regs() and vlynq_dump_mem() are unused ,so when
CONFIG_VLYNQ_DEBUG=y,a compilation issue occurred.
drivers/vlynq/vlynq.c:82:13: error: ‘vlynq_dump_mem’ defined but not used [-Werror=unused-function]
drivers/vlynq/vlynq.c:68:13: error: ‘vlynq_dump_regs’ defined but not used [-Werror=unused-function]

  we can add __always_unused to fix it.

Reported-by: k2ci <kernel-bot@...inos.cn>
Signed-off-by: tianyaxiong <tianyaxiong@...inos.cn>
---
 drivers/vlynq/vlynq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 4af6615808cc..6b6d6ad8ee1f 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -65,7 +65,7 @@ struct vlynq_regs {
 };
 
 #ifdef CONFIG_VLYNQ_DEBUG
-static void vlynq_dump_regs(struct vlynq_device *dev)
+static void __always_unused vlynq_dump_regs(struct vlynq_device *dev)
 {
 	int i;
 
@@ -79,7 +79,7 @@ static void vlynq_dump_regs(struct vlynq_device *dev)
 	}
 }
 
-static void vlynq_dump_mem(u32 *base, int count)
+static void __always_unused vlynq_dump_mem(u32 *base, int count)
 {
 	int i;
 
-- 
2.25.1