linux-kernel - Re: [PATCH] ARM: dts: aspeed: mtmitchell: Enable NCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8980c1b2-e7ae-e1b4-9f22-ac374bead4ef@amperemail.onmicrosoft.com>
Date:   Tue, 21 Feb 2023 14:29:20 +0700
From:   Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Chanh Nguyen <chanh@...amperecomputing.com>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: aspeed: mtmitchell: Enable NCSI



On 17/02/2023 18:32, Krzysztof Kozlowski wrote:
> On 17/02/2023 11:21, Chanh Nguyen wrote:
>> Support the mac3 (RGMII4) as an NC-SI stack instead of an MDIO PHY.
>>
>> The OCP slot #0 and OCP slot #1 use a common the BMC_NCSI signal,
>> so we use only one of them at the same time. The OCP slot #0 will
>> be enabled by PCA9539's setting by default.
>>
>> Also, enable the OCP Auxiliary Power during booting.
>>
>> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
>> ---
>>   .../boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 37 ++++++++++++++++++-
>>   1 file changed, 36 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> index 4b91600eaf62..e8a6b1f08d6a 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -251,6 +251,14 @@
>>   	pinctrl-0 = <&pinctrl_rgmii1_default>;
>>   };
>>   
>> +&mac3 {
>> +	status = "okay";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_rmii4_default>;
>> +	clock-names = "MACCLK", "RCLK";
>> +	use-ncsi;
>> +};
>> +
>>   &fmc {
>>   	status = "okay";
>>   	flash@0 {
>> @@ -439,6 +447,26 @@
>>   	status = "okay";
>>   };
>>   
>> +&i2c8 {
>> +	status = "okay";
>> +
>> +	pca9539@77 {
> 
> Node names should be generic, so I believe this is "gpio".
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> Best regards,
> Krzysztof
> 

Thank Krzysztof,

The PCA9539APW is a GPIO expander via I2C. For a generic name, I think 
the "gpio" is suitable.