[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d7fe795-66b9-7a07-b754-77327886c6c6@loongson.cn>
Date: Tue, 21 Feb 2023 17:48:40 +0800
From: Tianrui Zhao <zhaotianrui@...ngson.cn>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: Huacai Chen <chenhuacai@...nel.org>,
WANG Xuerui <kernel@...0n.name>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
kvm@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
Mark Brown <broonie@...nel.org>,
Alex Deucher <alexander.deucher@....com>,
Oliver Upton <oliver.upton@...ux.dev>, maobibo@...ngson.cn
Subject: Re: [PATCH v2 22/29] LoongArch: KVM: Implement handle idle exception
在 2023年02月21日 02:40, Paolo Bonzini 写道:
> On 2/20/23 07:57, Tianrui Zhao wrote:
>> +int _kvm_emu_idle(struct kvm_vcpu *vcpu)
>> +{
>> + ++vcpu->stat.idle_exits;
>> + trace_kvm_exit(vcpu, KVM_TRACE_EXIT_IDLE);
>
> Please add a separate tracepoint, don't overload trace_kvm_exit().
>
> Likewise for _kvm_trap_handle_gspr().
>
> I think _kvm_trap_handle_gspr() should have a tracepoint whose
> parameter is inst.word.
Thanks, I will add the tracepoint for _kvm_emu_idle and
_kvm_trap_handle_gspr.
Thanks
Tianrui Zhao
>
> Paolo
>
>> + if (!vcpu->arch.irq_pending) {
>> + kvm_save_timer(vcpu);
>> + kvm_vcpu_block(vcpu);
>> + }
>> +
>> + return EMULATE_DONE;
Powered by blists - more mailing lists