linux-kernel - Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc0c458c-8c4b-c187-8b65-5943499ddf94@linaro.org>
Date:   Tue, 21 Feb 2023 11:36:52 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Keguang Zhang <keguang.zhang@...il.com>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based
 boards

On 21/02/2023 11:26, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> ---
> V1 -> V2: Add the according vendor prefix
>           Change the board string to enum
>           Modify the board description

Thank you for your patch. There is something to discuss/improve.

> ---
>  .../devicetree/bindings/mips/loongson/devices.yaml   | 12 ++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml         |  2 ++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..15a43ce51bbf 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,18 @@ properties:
>          items:
>            - const: loongson,loongson64v-4core-virtio
>  
> +      - description: LS1B based boards
> +        items:
> +          - enum:
> +              - loongson,lsgz-1b-dev
> +          - const: loongson,ls1b
> +
> +      - description: LS1C based boards
> +        items:
> +          - enum:
> +              - loongsonclub,smartloong-1c
> +          - const: loongson,ls1c
> +
>  additionalProperties: true
>  
>  ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 0e57ae744199..47565ebae4d1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -757,6 +757,8 @@ patternProperties:
>      description: Lontium Semiconductor Corporation
>    "^loongson,.*":
>      description: Loongson Technology Corporation Limited
> +  "^loongsonclub,.*":
> +    description: Loongson Club

Are you sure that this is a board manufacturer?

Best regards,
Krzysztof