linux-kernel - Re: [PATCH bpf-next] bpf: Add bpf_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQL0Zf3Dq=6wCMmj+R9bz1B1J4b=mUkvkObKfPQprUjyag@mail.gmail.com>
Date:   Wed, 22 Feb 2023 13:20:19 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        bpf <bpf@...r.kernel.org>,
        Dave Marchevsky <davemarchevsky@...a.com>,
        David Vernet <void@...ifault.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Kernel Team <kernel-team@...a.com>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_cgroup_from_id() kfunc

On Tue, Feb 21, 2023 at 2:09 PM Tejun Heo <tj@...nel.org> wrote:
>
> cgroup ID is an userspace-visible 64bit value uniquely identifying a given
> cgroup. As the IDs are used widely, it's useful to be able to look up the
> matching cgroups. Add bpf_cgroup_from_id().
>
> Signed-off-by: Tejun Heo <tj@...nel.org>
> ---
>  Documentation/bpf/kfuncs.rst                  | 10 +++--
>  kernel/bpf/helpers.c                          | 18 ++++++++
>  .../selftests/bpf/prog_tests/cgrp_kfunc.c     |  1 +
>  .../selftests/bpf/progs/cgrp_kfunc_common.h   |  1 +
>  .../selftests/bpf/progs/cgrp_kfunc_success.c  | 42 +++++++++++++++++++
>  5 files changed, 69 insertions(+), 3 deletions(-)

Looks great, but could you please split it into two patches:
One for helpers.c and kfuncs.rst and another for selftests
with [PATCH bpf-next] selftests/bpf: subject ?
Doesn't matter much in this case, but it might ease backporting
and easier to track patches grouped by subj.