linux-kernel - Re: [PATCH v4 1/4] locktorture: Add nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2023 13:35:01 -0800
From:   John Stultz <jstultz@...gle.com>
To:     paulmck@...nel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Josh Triplett <josh@...htriplett.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        kernel-team@...roid.com, "Connor O'Brien" <connoro@...gle.com>
Subject: Re: [PATCH v4 1/4] locktorture: Add nested_[un]lock() hooks and
 nlocks parameter

On Wed, Feb 22, 2023 at 11:07 AM Paul E. McKenney <paulmck@...nel.org> wrote:
> On Tue, Feb 21, 2023 at 07:02:35PM +0000, John Stultz wrote:
> > In order to extend locktorture to support lock nesting, add
> > nested_lock() and nested_unlock() hooks to the torture ops.
> >
> > These take a 32bit lockset mask which is generated at random,
> > so some number of locks will be taken before the main lock is
> > taken and released afterwards.
> >
> > Additionally, add nested_locks module parameter to allow
> > specifying the number of nested locks to be used.
> >
> > This has been helpful to uncover issues in the proxy-exec
> > series development.
> >
> > This was inspired by locktorture extensions originally implemented
> > by Connor O'Brien, for stress testing the proxy-execution series:
> >   https://lore.kernel.org/lkml/20221003214501.2050087-12-connoro@google.com/
> >
> > Cc: Davidlohr Bueso <dave@...olabs.net>
> > Cc: "Paul E. McKenney" <paulmck@...nel.org>
> > Cc: Josh Triplett <josh@...htriplett.org>
> > Cc: Joel Fernandes <joel@...lfernandes.org>
> > Cc: Juri Lelli <juri.lelli@...hat.com>
> > Cc: Valentin Schneider <vschneid@...hat.com>
> > Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> > Cc: kernel-team@...roid.com
> > Reviewed-by: Davidlohr Bueso <dave@...olabs.net>
> > Co-developed-by: Connor O'Brien <connoro@...gle.com>
> > Signed-off-by: Connor O'Brien <connoro@...gle.com>
> > Signed-off-by: John Stultz <jstultz@...gle.com>
>
> I queued this series in place of its precedessor, thank you for the
> update!
>
> Given what I know now, I will set this up for the v6.4 merge window.

Much appreciated! Apologies for the churn, I wasn't sure if you caught
the last iteration or not, so I figured I'd send it out again.

thanks
-john