linux-kernel - Re: [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node regex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c814f58e-c266-f889-69b2-88c67aa1e041@ti.com>
Date:   Wed, 22 Feb 2023 10:05:32 +0530
From:   Ravi Gunasekaran <r-gunasekaran@...com>
To:     Vignesh Raghavendra <vigneshr@...com>, <nm@...com>, <afd@...com>,
        <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <s-vadapalli@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix
 mux node regex



On 21/02/23 7:29 pm, Vignesh Raghavendra wrote:
> 
> 
> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote:
>> mux-controller nodes may not have "reg" property. Update the regex
>> for such nodes to resolve the dtbs warnings
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@...com>
>> ---
>>  .../bindings/mfd/ti,j721e-system-controller.yaml          | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> index 76ef4352e13c..532bfa45e6a0 100644
>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> @@ -45,7 +45,7 @@ properties:
>>  
>>  patternProperties:
>>    # Optional children
>> -  "^mux-controller@[0-9a-f]+$":
>> +  "^mux-controller(@|-)[0-9a-f]+$":
> 
> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to
> mux-controller node in 2/9 ?

"reg" property can be added to the mux-controller node.
I will do so in the next series

> 
>>      type: object
>>      description:
>>        This is the SERDES lane control mux.
>> @@ -94,6 +94,12 @@ examples:
>>                  /* SERDES4 lane0/1/2/3 select */
>>          };
>>  
>> +        usb_serdes_mux: mux-controller-80 {
>> +                compatible = "mmio-mux";
>> +                #mux-control-cells = <1>;
>> +                mux-reg-masks = <0x0 0x8000000>;
>> +        };
>> +
>>          clock-controller@...0 {
>>              compatible = "ti,am654-ehrpwm-tbclk", "syscon";
>>              reg = <0x4140 0x18>;

-- 
Regards,
Ravi