linux-kernel - Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org>
Date:   Wed, 22 Feb 2023 08:16:04 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Florian Eckert <fe@....tdt.de>, kernel test robot <lkp@...el.com>
Cc:     u.kleine-koenig@...gutronix.de, gregkh@...uxfoundation.org,
        pavel@....cz, lee@...nel.org, oe-kbuild-all@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        Eckert.Florian@...glemail.com
Subject: Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes

On 22. 02. 23, 7:07, Florian Eckert wrote:
> 
> 
> On 2023-02-22 01:02, kernel test robot wrote:
>> Hi Florian,
>>
>> Thank you for the patch! Perhaps something to improve:
>>
>> [auto build test WARNING on tty/tty-testing]
>> [also build test WARNING on tty/tty-next tty/tty-linus
>> staging/staging-testing staging/staging-next staging/staging-linus
>> pavel-leds/for-next linus/master v6.2 next-20230221]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
>> tty-testing
>> patch link: 
>> https://lore.kernel.org/r/20230221081901.15557-3-fe%40dev.tdt.de
>> patch subject: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
>> reproduce:
>>         #
>> https://github.com/intel-lab-lkp/linux/commit/445b7555bccd279bf106995ee42f5dbef2e97c8b
>>         git remote add linux-review 
>> https://github.com/intel-lab-lkp/linux
>>         git fetch --no-tags linux-review
>> Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
>>         git checkout 445b7555bccd279bf106995ee42f5dbef2e97c8b
>>         make menuconfig
>>         # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS,
>> CONFIG_WARN_ABI_ERRORS
>>         make htmldocs
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Link:
>> https://lore.kernel.org/oe-kbuild-all/202302220740.2RKDHnof-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: 
>>>> Unexpected indentation.
>>>> Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: 
>>>> Block quote ends without a blank line; unexpected unindent.
>>
>> vim +9 Documentation/ABI/testing/sysfs-class-led-trigger-tty
>>
>>    > 9    Date:        January 2023
> 
> I apologies for the question! But I don't know what the test buildbot 
> here wants from me.
> I've looked at the other files and I can't find anything that stands out.

sphinx is always misleading.

It's the indentation of all "LED on if ...".

-- 
js
suse labs