linux-kernel - Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <934e866942bd8d413bbb4570741e5d8d1537f211.camel@sipsolutions.net>
Date:   Wed, 22 Feb 2023 09:00:59 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Wen Gong <quic_wgong@...cinc.com>,
        "Youghandhar Chintala (Temp)" <quic_youghand@...cinc.com>,
        ath10k@...ts.infradead.org
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_mpubbise@...cinc.com
Subject: Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support

On Wed, 2023-02-22 at 08:22 +0800, Wen Gong wrote:
> On 2/15/2023 11:10 PM, Johannes Berg wrote:
> > > > Why is this even needed? You should always get reg_notifier after this
> > > > anyway?
> > > Currently when channel flag changed through the beacon hints are not
> > > informed to driver.
> > > 
> > > reg_notifier will be triggered for regdomain changes but not for channel flag changes due to beacon hints.
> > > 
> > So maybe triggering reg notifier once would be sufficient, a la Wen's
> > patch that I recently merged?
> 
> My patch only take effect for this flag, not for all wiphy.
> 
> if (wiphy->flags & WIPHY_FLAG_NOTIFY_REGDOM_BY_DRIVER)
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit?id=d99975c4953eb79e389d4630e848435c700e2dfc
> 

Oh sure, I meant this patch could do something similar, instead of
introducing a new notifier callback.

johannes