linux-kernel - Re: [PATCH v4 49/54] clk: mediatek: Add MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5274b05e-194f-131c-bedd-6b879a8ff946@collabora.com>
Date:   Wed, 22 Feb 2023 10:05:41 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Miles Chen <miles.chen@...iatek.com>
Cc:     chen.zhong@...iatek.com, chun-jie.chen@...iatek.com,
        daniel@...rotopia.org, edward-jw.yang@...iatek.com,
        fparent@...libre.com, granquet@...libre.com,
        johnson.wang@...iatek.com, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, matthias.bgg@...il.com,
        msp@...libre.com, mturquette@...libre.com, nfraprado@...labora.com,
        pablo.sun@...iatek.com, rex-bc.chen@...iatek.com,
        sam.shih@...iatek.com, sboyd@...nel.org, sean.wang@...iatek.com,
        wenst@...omium.org, yangyingliang@...wei.com, zhaojh329@...il.com
Subject: Re: [PATCH v4 49/54] clk: mediatek: Add MODULE_DEVICE_TABLE() where
 appropriate

Il 22/02/23 05:14, Miles Chen ha scritto:
> Hi,
> 
>> static struct platform_driver clk_mt8195_venc_drv = {
>> 	.probe = mtk_clk_simple_probe,
>> diff --git a/drivers/clk/mediatek/clk-mt8195-vpp0.c b/drivers/clk/mediatek/clk-mt8195-vpp0.c
>> index 84805a114387..3d1ad92b663e 100644
>> --- a/drivers/clk/mediatek/clk-mt8195-vpp0.c
>> +++ b/drivers/clk/mediatek/clk-mt8195-vpp0.c
>> @@ -95,6 +95,7 @@ static const struct platform_device_id clk_mt8195_vpp0_id_table[] = {
>> 	{ .name = "clk-mt8195-vpp0", .driver_data = (kernel_ulong_t)&vpp0_desc },
>> 	{ /* sentinel */ }
>> };
>> +MODULE_DEVICE_TABLE(platform, of_match_clk_mt8195_vpp0);
>>
>> static struct platform_driver clk_mt8195_vpp0_drv = {
>> 	.probe = mtk_clk_pdev_probe,
>> diff --git a/drivers/clk/mediatek/clk-mt8195-vpp1.c b/drivers/clk/mediatek/clk-mt8195-vpp1.c
>> index 3e91dfed2996..b463f8e197c6 100644
>> --- a/drivers/clk/mediatek/clk-mt8195-vpp1.c
>> +++ b/drivers/clk/mediatek/clk-mt8195-vpp1.c
>> @@ -93,6 +93,7 @@ static const struct platform_device_id clk_mt8195_vpp1_id_table[] = {
>> 	{ .name = "clk-mt8195-vpp1", .driver_data = (kernel_ulong_t)&vpp1_desc },
>> 	{ /* sentinel */ }
>> };
>> +MODULE_DEVICE_TABLE(platform, of_match_clk_mt8195_vpp1);
> 
> I got the following build break with ARCH=arm64 allmodconfig:
> Do I miss something?
> 
> linux-next/drivers/clk/mediatek/clk-mt8195-vpp0.c:98:31: error: 'of_match_clk_mt8195_vpp0' undeclared here (not in a function)
> linux-next/drivers/clk/mediatek/clk-mt8195-vpp1.c:96:31: error: 'of_match_clk_mt8195_vpp1' undeclared here (not in a function)
> 
> ARCH=arm64 allyesconfig, defconfig: passed
> 
> thanks,
> Miles

Sorry, this one was meant to be `clk_mt8195_vpp1_id_table` instead of
`of_match_clk_mt8195_vpp1`.... something went wrong with the rebase.

I'll fix that asap.

Thanks,
Angelo