linux-kernel - Re: [PATCH -next] net/mlx5: Remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Feb 2023 11:34:23 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     kuba@...nel.org, davem@...emloft.net, saeedm@...dia.com,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold}

On Wed, Feb 22, 2023 at 10:29:44AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning：
> 
> ./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Please submit this patch with fixed title from -next to be net-next
after merge window.

Thanks