linux-kernel - Re: [PATCH v3 0/6] Add support for Qualcomm's legacy IOMMU v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <254cfbb5-c8b8-0abc-e6bc-5007fe757004@collabora.com>
Date:   Wed, 22 Feb 2023 10:57:47 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     agross@...nel.org
Cc:     andersson@...nel.org, konrad.dybcio@...aro.org, joro@...tes.org,
        will@...nel.org, robin.murphy@....com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, robdclark@...il.com,
        linux-arm-msm@...r.kernel.org, iommu@...ts.linux.dev,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        marijn.suijten@...ainline.org, kernel@...labora.com,
        luca@...tu.xyz, a39.skl@...il.com, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v3 0/6] Add support for Qualcomm's legacy IOMMU v2

Il 15/11/22 11:11, AngeloGioacchino Del Regno ha scritto:
> This series adds support for handling "v2" firmware's IOMMU, found
> on at least MSM8956 and MSM8976 (some other SoCs also need the same
> but I honestly don't remember which ones precisely).
> 
> This is strictly required to get functional IOMMUs on these SoCs.
> 
> I'm sorry for not performing a much needed schema conversion on
> qcom,iommu.txt, but I really didn't have time to do that :-(
> 
> This series was tested on Sony Xperia X and X Compact (MSM8956):
> ADSP, LPASS, Venus, MSS, MDP and GPU are happy :-)
> 
> 

Hello,
this series is really old and got sent and resent many times.
The first time I've sent this one was .. I think in 2019, then, at the
end of 2022, I had some time to actually respin it and send another
three versions. It's been 3 long years :-)
The third version got the last comments addressed.

Since this didn't get any more feedback for 3 months, I'm worried that it
will be forgotten again, hence:

Is there any more feedback? Anything else to fix?
If not, can this be picked, please?

Thank you.

Best regards,
Angelo


> Changes in v3:
>   - Removed useless FSRRESTORE reset and definition as pointed
>     out in Robin Murphy's review
>   - Fixed qcom,iommu.txt changes: squashed MSM8976 compatible
>     string addition with msm-iommu-v2 generics addition
> 
> Changes in v2:
>   - Added back Marijn's notes (sorry man!)
>   - Added ARM_SMMU_CB_FSRRESTORE definition
>   - Changed context bank reset to properly set FSR and FSRRESTORE
> 
> AngeloGioacchino Del Regno (6):
>    dt-bindings: iommu: qcom,iommu: Document qcom,ctx-num property
>    iommu/qcom: Use the asid read from device-tree if specified
>    iommu/qcom: Properly reset the IOMMU context
>    iommu/qcom: Index contexts by asid number to allow asid 0
>    dt-bindings: iommu: qcom,iommu: Document QSMMUv2 and MSM8976
>      compatibles
>    iommu/qcom: Add support for QSMMUv2 and QSMMU-500 secured contexts
> 
>   .../devicetree/bindings/iommu/qcom,iommu.txt  |  9 +++
>   drivers/iommu/arm/arm-smmu/qcom_iommu.c       | 78 +++++++++++++++----
>   2 files changed, 70 insertions(+), 17 deletions(-)
>