linux-kernel - Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/XpClyi9KMtLKcF@valkosipuli.retiisi.eu>
Date:   Wed, 22 Feb 2023 12:06:02 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     shravan kumar <shravan.chippa@...rochip.com>,
        paul.j.murphy@...el.com, daniele.alessandrelli@...el.com,
        mchehab@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Jacopo Mondi <jacopo.mondi@...asonboard.com>,
        Prakash Battu <Prakash.Battu@...rochip.com>
Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode

On Wed, Feb 22, 2023 at 12:03:10PM +0200, Sakari Ailus wrote:
> On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:
> > On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:
> > > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:
> > > > From: Shravan Chippa <shravan.chippa@...rochip.com>
> > 
> > > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev *sd,
> > > >  	struct v4l2_subdev_format fmt = { 0 };
> > > >  
> > > >  	fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
> > > > -	imx334_fill_pad_format(imx334, &supported_mode, &fmt);
> > > > +	imx334_fill_pad_format(imx334, &supported_modes[0], &fmt);
> > > 
> > > Now that there are multiple modes supported, this would appear to get the
> > > width, height as well as the other fields (apart from mbus code) from the
> > > first mode.
> > 
> > Is this statement supposed to be a request to change something, or just
> > a throwaway comment? It's a little hard for me to understand your
> > intention here, sorry.
> 
> Just pointing to what looks like a bug.

Ah, my bad. Please ignore the comment.

This is indeed about init_cfg(), not s_fmt().

-- 
Sakari Ailus