linux-kernel - Re: [PATCH v10 2/9] arm64: dts: ti: k3-j721s2-main: Add support for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230222131559.day4frfvjuje25i4@suffrage>
Date:   Wed, 22 Feb 2023 07:15:59 -0600
From:   Nishanth Menon <nm@...com>
To:     Ravi Gunasekaran <r-gunasekaran@...com>
CC:     <afd@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <s-vadapalli@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/9] arm64: dts: ti: k3-j721s2-main: Add support for
 USB

On 10:21-20230222, Ravi Gunasekaran wrote:
[...]
> >> +	usbss0: cdns-usb@...4000 {
> >> +		compatible = "ti,j721e-usb";
> >> +		reg = <0x00 0x04104000 0x00 0x100>;
> >> +		clocks = <&k3_clks 360 16>, <&k3_clks 360 15>;
> >> +		clock-names = "ref", "lpm";
> >> +		assigned-clocks = <&k3_clks 360 16>; /* USB2_REFCLK */
> >> +		assigned-clock-parents = <&k3_clks 360 17>;
> >> +		power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>;
> >> +		#address-cells = <2>;
> >> +		#size-cells = <2>;
> >> +		ranges;
> >> +		dma-coherent;
> >> +
> >> +		status = "disabled";
> > 
> > Why disabled by default?
> 
> One of the comment received in the v9 series was to disable the node in
> the include file and then enable it in the board specific DTS file.
> Changes in this series addressed that comment.

Document in the node why it is disabled by default. Also do make sure
All K3 SoCs dtsi nodes follow the same argument.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D