linux-kernel - Re: [PATCH v10 0/8] i2c-atr and FPDLink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/YjlW2byyHKamxl@smile.fi.intel.com>
Date:   Wed, 22 Feb 2023 16:15:49 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc:     linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Rosin <peda@...ntia.se>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mike Pagano <mpagano@...too.org>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Marek Vasut <marex@...x.de>,
        Satish Nagireddy <satish.nagireddy@...cruise.com>
Subject: Re: [PATCH v10 0/8] i2c-atr and FPDLink

On Wed, Feb 22, 2023 at 03:28:59PM +0200, Tomi Valkeinen wrote:
> Hi,
> 
> You can find v9 from:
> 
> https://lore.kernel.org/all/20230216140747.445477-1-tomi.valkeinen@ideasonboard.com/
> 
> Diff to v9 included below.
> 
> Main changes in v10:
> - Switch pre-increments to post-increments
> - Add macros for FPD3_RX_ID lengths
> - Use regmap_bulk_read in 16 bit reg accessors

Thanks!
I have no more remarks, nice job!

One thing below to just look at and if you want / have time / chance update.

...

> +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);

sizeof()

...

> +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);

Ditto.

-- 
With Best Regards,
Andy Shevchenko