linux-kernel - Re: [PATCH] KVM: x86: Remove duplicated calls of reverse_cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46eb6fe5-0885-2537-099b-33d8bcfde1d3@linux.intel.com>
Date:   Wed, 22 Feb 2023 10:38:43 +0800
From:   Binbin Wu <binbin.wu@...ux.intel.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        pbonzini@...hat.com
Subject: Re: [PATCH] KVM: x86: Remove duplicated calls of
 reverse_cpuid_check()


On 2/21/2023 11:54 PM, Sean Christopherson wrote:
> On Tue, Feb 21, 2023, Binbin Wu wrote:
>> Remove duplicated calls of reverse_cpuid_check() in __kvm_cpu_cap_mask()
>> and kvm_cpu_cap_{clear, set, get}().
> I want to keep the checks even though they are redundant.  There is no runtime
> cost, and the intent of the direct calls in the "upper" helpers is as much to
> document their usage constraints (input feature must be a compile-time constant)
> as it is to enforce correctness.

Got it.