linux-kernel - Re: [PATCH] bpf: Fix undeclared function 'barrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKX0ZD=8Xu4U2H_vbyuNoXJv0UZ1OffUtqw3vs0v95ELQ@mail.gmail.com>
Date:   Wed, 22 Feb 2023 08:28:58 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH] bpf: Fix undeclared function 'barrier_nospec' warning

On Wed, Feb 22, 2023 at 7:33 AM Dave Hansen <dave.hansen@...el.com> wrote:
>
> On 2/22/23 07:03, Geert Uytterhoeven wrote:
> > On Wed, Feb 22, 2023 at 9:26 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
> >> Add the missing header for architectures that don't define
> >> the barrier_nospec() macro. The nospec.h header is added after the
> >> inclusion of barrier.h to avoid redefining the macro for architectures
> >> that already define barrier_nospec() in their respective barrier.h
> >> headers.
> >>
> >> Fixes: 74e19ef0ff80 ("uaccess: Add speculation barrier to copy_from_user()")
> >> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> >> ---
> >> Linus's master branch fails currently to build for arm64 without this commit.
> > Not just arm64 🙁
> > http://kisskb.ellerman.id.au/kisskb/head/5b7c4cabbb65f5c469464da6c5f614cbd7f730f2
>
> Thanks for the fix, and sorry for the breakage, folks!  Obviously:
>
> Tested-by: Dave Hansen <dave.hansen@...ux.intel.com>
>
> Now time to go make sure I have bpf turned on in all my cross builds.

Not clear why the broken commit got applied bypassing bpf@...r and not
going through BPF CI. :(

Yesterday I applied pretty much the same fix from Huacai Chen.

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=345d24a91c79f408e355c8b7e873ccde0f097eea

and BPF CI is now back to green.

Linus,
Since the blast radius is big, may be apply the fix directly ?