lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Feb 2023 11:04:18 +0800 From: Po-Wen Kao <powen.kao@...iatek.com> To: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>, Bart Van Assche <bvanassche@....org>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Matthias Brugger <matthias.bgg@...il.com> CC: <wsd_upstream@...iatek.com>, <peter.wang@...iatek.com>, <stanley.chu@...iatek.com>, <powen.kao@...iatek.com>, <alice.chao@...iatek.com>, <naomi.chu@...iatek.com>, <chun-hung.wu@...iatek.com>, <cc.chou@...iatek.com>, <eddie.huang@...iatek.com>, <mason.zhang@...iatek.com>, <chaotian.jing@...iatek.com>, <jiajie.hao@...iatek.com> Subject: [PATCH v2 1/7] scsi: ufs: core: Fix mcq tag calcualtion Transfer command descriptor is allocated in ufshcd_memory_alloc() and referenced by transfer request descriptor with stride size sizeof_utp_transfer_cmd_desc() instead of sizeof(struct utp_transfer_cmd_desc). Consequently, computing tag by address offset should also refer to the same stride. Signed-off-by: Po-Wen Kao <powen.kao@...iatek.com> Reviewed-by: Bart Van Assche <bvanassche@....org> Reviewed-by: Manivannan Sadhasivam <mani@...nel.org> Reviewed-by: Stanley Chu <stanley.chu@...iatek.com> --- drivers/ufs/core/ufs-mcq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index 31df052fbc41..3a27fa4b0024 100644 --- a/drivers/ufs/core/ufs-mcq.c +++ b/drivers/ufs/core/ufs-mcq.c @@ -265,7 +265,7 @@ static int ufshcd_mcq_get_tag(struct ufs_hba *hba, addr = (le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA) - hba->ucdl_dma_addr; - return div_u64(addr, sizeof(struct utp_transfer_cmd_desc)); + return div_u64(addr, sizeof_utp_transfer_cmd_desc(hba)); } static void ufshcd_mcq_process_cqe(struct ufs_hba *hba, -- 2.18.0
Powered by blists - more mailing lists