linux-kernel - [PATCH v4 0/3] Fix problems fetching TBT3 DROM from AMD USB4 routers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230223210743.9819-1-mario.limonciello@amd.com>
Date:   Thu, 23 Feb 2023 15:07:40 -0600
From:   Mario Limonciello <mario.limonciello@....com>
To:     <mika.westerberg@...ux.intel.com>, <linux-usb@...r.kernel.org>
CC:     <Sanju.Mehta@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH v4 0/3] Fix problems fetching TBT3 DROM from AMD USB4 routers

TBT3 devices when connected to an AMD USB4 router occasionally fail to
properly respond to requests for the DROM via bit banging.

Depending upon which part of the request failed will impact the severity.
A number of workarounds have been put in place to let the driver handle
the failed requests:

commit e87491a9fd4e3 ("thunderbolt: Retry DROM reads for more failure scenarios")
commit a283de3ec646f ("thunderbolt: Do not resume routers if UID is not set")
commit 6915812bbd109 ("thunderbolt: Do not make DROM read success compulsory")
commit f022ff7bf377 ("thunderbolt: Retry DROM read once if parsing fails")

Still even with these changes the failures do make it through. In comparing
other CM implementations utilized on AMD systems, they all access the
DROM directly from the NVM.

To avoid triggering this issue, try to get the DROM directly from the NVM
in Linux as well when devices have an LC.

v4:
 * Style fixups
 * Fixup for wrong path for USB4 devices

Mario Limonciello (3):
  thunderbolt: Adjust how NVM reading works
  thunderbolt: use `tb_eeprom_get_drom_offset` to discover DROM offset
  thunderbolt: Refactor DROM reading

 drivers/thunderbolt/eeprom.c | 219 +++++++++++++++++++----------------
 1 file changed, 122 insertions(+), 97 deletions(-)

-- 
2.34.1