linux-kernel - Re: [PATCH 5.15 00/37] 5.15.96-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 22:23:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>, stable@...r.kernel.org,
        patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de
Subject: Re: [PATCH 5.15 00/37] 5.15.96-rc2 review

On Thu, Feb 23, 2023 at 01:18:31PM -0800, Linus Torvalds wrote:
> On Thu, Feb 23, 2023 at 11:47 AM Nathan Chancellor <nathan@...nel.org> wrote:
> >
> > I can send a patch unless you want to take those changes directly, you
> > have half a commit message there already I think :)
> 
> Not being one of those old fogeys myself, I don't feel hugely motivated to care.
> 
> In fact, I think GNU patch implemented the git patch format extensions
> more than a decade ago, so we might even simply decide that it's past
> time to even worry about this at all.
> 
> In fact, with all the base infrastructure supporting git patches, I'm
> not quite sure just _how_ quilt is able to apply patches without
> dealing with mode bits.
> 
> Does quilt parse the patches and actively remove those lines before
> applying them? Or does quilt have some actual built-in patch
> application code that doesn't depend on GNU patch?
> 
> (Side note: GNU patch may support git patches, but I don't think GNU
> diffutils will generate them, so I guess not all base infrastructure
> supports that fancy new "mode" line)

Quilt should be depending on patch here, I think it's something in my
set of "turn this series of patches into a mbox, split the mbox up into
patches" sequence that is causing the problem.  I'll look into it in the
morning, but for now, I'm blaming my horrid scripts, not git or quilt
just yet...

thanks,

greg k-h