linux-kernel - Re: [6.3][regression] commit 2f5c3c77fc9b6a34b68b97231bfa970e1194ec28 definitely causes use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABXGCsP49H3TivoQKkBRos1Cx4zOVBUbbmXTrf-=1g2FBzs=gQ@mail.gmail.com>
Date:   Fri, 24 Feb 2023 02:28:36 +0500
From:   Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     Felix Fietkau <nbd@....name>, deren.wu@...iatek.com,
        Linux List Kernel Mailing <linux-wireless@...r.kernel.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [6.3][regression] commit 2f5c3c77fc9b6a34b68b97231bfa970e1194ec28
 definitely causes use-after-free

On Thu, Feb 23, 2023 at 10:38 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Hi Mike,
>
> can you please check if the patch below fixes the issue?
>
> Regards,
> Lorenzo
>
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
> index b88959ef38aa..5e5c7bf51174 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -706,6 +706,7 @@ mt76u_free_rx_queue(struct mt76_dev *dev, struct mt76_queue *q)
>                 q->entry[i].urb = NULL;
>         }
>         page_pool_destroy(q->page_pool);
> +       q->page_pool = NULL;
>  }
>
>  static void mt76u_free_rx(struct mt76_dev *dev)
>
>

Thanks, with this patch use-after-free issue gone.

Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@...il.com>

-- 
Best Regards,
Mike Gavrilov.