linux-kernel - RE: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM4PR12MB527834BFE80456BF1F3907559CAB9@DM4PR12MB5278.namprd12.prod.outlook.com>
Date:   Thu, 23 Feb 2023 07:10:00 +0000
From:   "Yuan, Perry" <Perry.Yuan@....com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        "Huang, Ray" <Ray.Huang@....com>
CC:     "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Yuan, Perry" <Perry.Yuan@....com>
Subject: RE: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is
 disabled

[AMD Official Use Only - General]


> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Sent: Thursday, February 23, 2023 3:03 PM
> To: Huang, Ray <Ray.Huang@....com>
> Cc: Limonciello, Mario <Mario.Limonciello@....com>; Kai-Heng Feng
> <kai.heng.feng@...onical.com>; Rafael J. Wysocki <rafael@...nel.org>; Viresh
> Kumar <viresh.kumar@...aro.org>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled
> 
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver parameter
> for mode selection") changed the driver to be disabled by default, and this can
> surprise users.
> 
> Let users know what happened so they can decide what to do next.
> 
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
> 
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>  	 * with amd_pstate=passive or other modes in kernel command line
>  	 */
>  	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to
> enable this\n");
> +		pr_info("driver load is disabled, boot with specific mode to
> enable
> +this\n");
>  		return -ENODEV;
>  	}
> 
> --
> 2.34.1
Thanks for the change. 

Reviewed-by : Yuan Perry <Perry.Yuan@....com>