linux-kernel - Re: [PATCH RFC 2/4] dt-bindings: clock: break out mediatek,ethsys into its own header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b834bea9-8370-5bc1-8edd-c4b62287e837@linaro.org>
Date:   Thu, 23 Feb 2023 11:19:56 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Daniel Golle <daniel@...rotopia.org>, linux-clk@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Edward-JW Yang <edward-jw.yang@...iatek.com>,
        Johnson Wang <johnson.wang@...iatek.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Miles Chen <miles.chen@...iatek.com>,
        Sam Shih <sam.shih@...iatek.com>
Subject: Re: [PATCH RFC 2/4] dt-bindings: clock: break out mediatek,ethsys
 into its own header

On 22/02/2023 19:09, Daniel Golle wrote:
> The ethsys clocks of MT7981 and MT7986 are identical. In order to
> de-duplicate both clock drivers, start with putting ethsys into a
> header files of its own, so it can be used by both SoCs.
> Propagate this change also to mt7986a.dtsi which is the only user.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
>  arch/arm64/boot/dts/mediatek/mt7986a.dtsi     |  1 +
>  drivers/clk/mediatek/clk-mt7986-eth.c         |  2 +-
>  include/dt-bindings/clock/mediatek,ethsys.h   | 32 +++++++++++++++++++

A bit too generic name. Are you sure it will fit all of eth on all
Mediatek SoCs? Current and future?

>  .../dt-bindings/clock/mediatek,mt7981-clk.h   | 18 -----------
>  .../dt-bindings/clock/mediatek,mt7986-clk.h   | 22 -------------

Same problems as previous patch. You cannot mix bindings and DTS and
drivers.

Best regards,
Krzysztof