linux-kernel - Re: [PATCH v1 char-misc-next 2/5] misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 11:29:49 +0100
From:   Michael Walle <michael@...le.cc>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     kumaravel.thiagarajan@...rochip.com, UNGLinuxDriver@...rochip.com,
        arnd@...db.de, derek.kiernan@...inx.com, dragan.cvetic@...inx.com,
        gregkh@...uxfoundation.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 char-misc-next 2/5] misc: microchip: pci1xxxx: load
 gpio driver for the gpio controller auxiliary device enumerated by the
 auxiliary bus driver.

Am 2023-02-23 11:23, schrieb Linus Walleij:
> On Fri, Feb 17, 2023 at 11:31 AM Michael Walle <michael@...le.cc> 
> wrote:
>> [+ GPIO maintainers]
>> 
>> > PIO function's auxiliary bus driver enumerates separate child devices for
>> > GPIO controller and OTP/EEPROM interface. This gpio driver implemented
>> > based on the gpio framework is loaded for the gpio auxiliary device.
>> >
>> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
>> > ---
>> >  MAINTAINERS                                   |   1 +
>> >  drivers/misc/mchp_pci1xxxx/Makefile           |   2 +-
>> >  .../misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c   | 163 ++++++++++++++++++
>> 
>> Why doesn't this file live in the GPIO subsystem? Seems like this 
>> haven't
>> got a proper review from the GPIO people (probably due to the "misc:"
>> subject). Maybe even GPIO_REGMAP could be used.
> 
> I agree, plese resend this patch with the linux-gpio mailing list and 
> the GPIO
> maintainers on CC.

This is already in drivers/misc. There should be a follow up patch.

-michael