linux-kernel - Re: [PATCH 11/27] kbuild, clk: bcm2835: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/bDOeY+O6KsJFNw@bombadil.infradead.org>
Date:   Wed, 22 Feb 2023 17:36:57 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Nick Alcock <nick.alcock@...cle.com>,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        Michael Turquette <mturquette@...libre.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        linux-clk@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 11/27] kbuild, clk: bcm2835: remove MODULE_LICENSE in
 non-modules

On Wed, Feb 22, 2023 at 03:43:40PM -0800, Stephen Boyd wrote:
> Quoting Nick Alcock (2023-02-22 04:14:37)
> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> > are used to identify modules. As a consequence, uses of the macro
> > in non-modules will cause modprobe to misidentify their containing
> > object file as a module when it is not (false positives), and modprobe
> > might succeed rather than failing with a suitable error message.
> > 
> > So remove it in the files in this commit, none of which can be built as
> > modules.
> > 
> > Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> > Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: linux-modules@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> > Cc: Michael Turquette <mturquette@...libre.com>
> > Cc: Stephen Boyd <sboyd@...nel.org>
> > Cc: Florian Fainelli <f.fainelli@...il.com>
> > Cc: Ray Jui <rjui@...adcom.com>
> > Cc: Scott Branden <sbranden@...adcom.com>
> > Cc: linux-clk@...r.kernel.org
> > Cc: linux-rpi-kernel@...ts.infradead.org
> > Cc: linux-arm-kernel@...ts.infradead.org
> > ---
> 
> Acked-by: Stephen Boyd <sboyd@...nel.org>
> 
> Unless you want me to pick this up?

Up to you, you can pick it up, and by rc3 of the next kernel I pick up
the last stragglers that no one picks up as reflected on linux-next.

  Luis