linux-kernel - Re: [PATCH] macintosh: via-pmu-led: *********************************

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e5c3c59-68c1-eb45-d462-bb093aee5da3@infradead.org>
Date:   Thu, 23 Feb 2023 07:51:01 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Michael Ellerman <mpe@...erman.id.au>, linux-kernel@...r.kernel.org
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Elimar Riesebieter <riesebie@...ec.de>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] macintosh: via-pmu-led: *********************************



On 2/23/23 00:56, Michael Ellerman wrote:
> Randy Dunlap <rdunlap@...radead.org> writes:
>> LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
>> when ATA is not set/enabled causes a Kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
>>   Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
>>   Selected by [y]:
>>   - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
>>
>> Fix this by making ADB_PMU_LED_DISK depend on ATA.
> 
> Should it just depend on LEDS_TRIGGER_DISK ?

Hmph. Yes, good idea. Thanks.

> 
>> Seen on both PPC32 and PPC64.
>>
>> Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> Cc: Paul Mackerras <paulus@...ba.org>
>> Cc: Elimar Riesebieter <riesebie@...ec.de>
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> ---
>>  drivers/macintosh/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
>> --- a/drivers/macintosh/Kconfig
>> +++ b/drivers/macintosh/Kconfig
>> @@ -86,6 +86,7 @@ config ADB_PMU_LED
>>  
>>  config ADB_PMU_LED_DISK
>>  	bool "Use front LED as DISK LED by default"
>> +	depends on ATA
>>  	depends on ADB_PMU_LED
>>  	depends on LEDS_CLASS
>>  	select LEDS_TRIGGERS

-- 
~Randy