linux-kernel - Re: [PATCH 5.15 00/37] 5.15.96-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1552656-7af0-42cf-017e-df919b0d0585@linuxfoundation.org>
Date:   Thu, 23 Feb 2023 09:18:09 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nathan Chancellor <nathan@...nel.org>
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        llvm@...ts.linux.dev, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 5.15 00/37] 5.15.96-rc2 review

On 2/23/23 08:45, Shuah Khan wrote:
> On 2/23/23 08:40, Naresh Kamboju wrote:
>> On Thu, 23 Feb 2023 at 19:46, Greg Kroah-Hartman
>> <gregkh@...uxfoundation.org> wrote:
>>>
>>> This is the start of the stable review cycle for the 5.15.96 release.
>>> There are 37 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 25 Feb 2023 14:15:30 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.96-rc2.gz
>>> or in the git tree and branch at:
>>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Following build warnings / error notices on 5.15-rc2
>> anyone see these build issues ?
>>
>> scripts/pahole-flags.sh: 10: scripts/pahole-version.sh: Permission denied
>> scripts/pahole-flags.sh: 12: [: Illegal number:
>> scripts/pahole-flags.sh: 16: [: Illegal number:
>> scripts/pahole-flags.sh: 20: [: Illegal number:
>> scripts/pahole-flags.sh: 10: scripts/pahole-version.sh: Permission denied
>> scripts/pahole-flags.sh: 12: [: Illegal number:
>> scripts/pahole-flags.sh: 16: [: Illegal number:
>> scripts/pahole-flags.sh: 20: [: Illegal number:
>> scripts/pahole-flags.sh: 10: scripts/pahole-version.sh: Permission denied
>> scripts/pahole-flags.sh: 12: [: Illegal number:
>> scripts/pahole-flags.sh: 16: [: Illegal number:
>> scripts/pahole-flags.sh: 20: [: Illegal number:
>> sh: 1: scripts/pahole-version.sh: Permission denied
>> init/Kconfig:97: syntax error
>> init/Kconfig:96: invalid statement
>> make[2]: *** [scripts/kconfig/Makefile:87: defconfig] Error 1
>>
>>
>> Need to bisect
>> -- 
>>
>> commit 54fab3cc806aec70d7ce8440e511d56bd53a4081
>> Author: Nathan Chancellor <nathan@...nel.org>
>> Date:   Tue Feb 1 13:56:21 2022 -0700
>>
>>      kbuild: Add CONFIG_PAHOLE_VERSION
>>
>>      commit 613fe169237785a4bb1d06397b52606b2967da53 upstream.
>>
>>      There are a few different places where pahole's version is turned into a
>>      three digit form with the exact same command. Move this command into
>>      scripts/pahole-version.sh to reduce the amount of duplication across the
>>      tree.
>>
>>      Create CONFIG_PAHOLE_VERSION so the version code can be used in Kconfig
>>      to enable and disable configuration options based on the pahole version,
>>      which is already done in a couple of places.
>>
>>      Signed-off-by: Nathan Chancellor <nathan@...nel.org>
>>
>> -- 
>> ls -l   scripts/pahole*.sh
>> -rwxr-xr-x 1 naresh naresh 610 Feb 23 21:03 scripts/pahole-flags.sh
>> -rw-r--r-- 1 naresh naresh 269 Feb 23 21:03 scripts/pahole-version.sh
>>
>>
>>
>> -- 
>> Linaro LKFT
>> https://lkft.linaro.org
>>
> +1 seeing the same:
> 
> ./scripts/pahole-flags.sh: 10: ./scripts/pahole-version.sh: Permission denied
> ./scripts/pahole-flags.sh: 12: [: Illegal number:
> ./scripts/pahole-flags.sh: 16: [: Illegal number:
> ./scripts/pahole-flags.sh: 20: [: Illegal number:
> 
> 

Okay figured out problem now. scripts/pahole-version.sh isn't executable.
Once I made that change make is working now:

chmod +x scripts/pahole-version.sh

thanks,
-- Shuah