linux-kernel - Re: [PATCH v2 1/1] regmap-irq: Place kernel doc of struct regmap_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/e19Oqf1XwDo/aw@smile.fi.intel.com>
Date:   Thu, 23 Feb 2023 20:52:36 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     William Breathitt Gray <william.gray@...aro.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] regmap-irq: Place kernel doc of struct
 regmap_irq_chip in order

On Wed, Feb 22, 2023 at 11:43:28AM -0500, William Breathitt Gray wrote:
> On Mon, Feb 20, 2023 at 05:33:34PM +0200, Andy Shevchenko wrote:
> > It seems that a couple of members got lost theirorder, put them back.
> 
> Looks like a typographical error here: "theirorder".

Ah, thanks!

...

> >  	unsigned int use_ack:1;
> >  	unsigned int ack_invert:1;
> >  	unsigned int clear_ack:1;
> > +	unsigned int status_invert:1;
> >  	unsigned int wake_invert:1;
> > -	unsigned int runtime_pm:1;
> >  	unsigned int type_in_mask:1;
> >  	unsigned int clear_on_unmask:1;
> > +	unsigned int runtime_pm:1;
> >  	unsigned int not_fixed_stride:1;
> > -	unsigned int status_invert:1;
> 
> These don't look alphabetical, so what is the order for these?

Nope, the order is to follow:
a) kernel doc
b) semantics of each of the groups

Do you think the order can be improved? Can you point out how?

-- 
With Best Regards,
Andy Shevchenko