linux-kernel - Re: [GIT PULL] TTY/Serial driver updates for 6.3-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whhFCeeuo6vTEmNSx6S-KKkugxgzN_W5Z6v-9yH9gc3Zw@mail.gmail.com>
Date:   Fri, 24 Feb 2023 13:24:05 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>,
        Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jiri Slaby <jslaby@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [GIT PULL] TTY/Serial driver updates for 6.3-rc1

On Fri, Feb 24, 2023 at 4:51 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
>   - more 8250 device support added

Bah. I didn't notice this while merging, so it's in my tree now, but
that SERIAL_8250_PCI1XXXX shouldn't default to on.

The Kconfig file has

    config SERIAL_8250_PCI1XXXX
        tristate "Microchip 8250 based serial port"
        depends on SERIAL_8250 && PCI
        select SERIAL_8250_PCILIB
        default SERIAL_8250
        ...

and I don't think that "default" line should exist. It's not like this
is some super-common board that everybody should enable.

When I notice things in time, I tend to just fix this up in the merge
itself, but this time I had already done a couple of other of your
pulls before I noticed this thing.

            Linus