linux-kernel - Re: [RFC PATCH 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f8621a3-1043-c68a-e305-277ade14b939@quicinc.com>
Date:   Fri, 24 Feb 2023 13:24:47 -0800
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>,
        <dri-devel@...ts.freedesktop.org>, <robdclark@...il.com>,
        <sean@...rly.run>, <swboyd@...omium.org>, <dianders@...omium.org>,
        <vkoul@...nel.org>, <daniel@...ll.ch>, <airlied@...il.com>,
        <agross@...nel.org>, <andersson@...nel.org>
CC:     <marijn.suijten@...ainline.org>, <quic_sbillaka@...cinc.com>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [RFC PATCH 2/2] drm/msm/dsi: use new
 dpu_dsc_populate_dsc_config()



On 2/24/2023 1:14 PM, Dmitry Baryshkov wrote:
> On 24/02/2023 23:09, Abhinav Kumar wrote:
>>
>>
>> On 2/24/2023 1:04 PM, Dmitry Baryshkov wrote:
>>> On 24/02/2023 21:40, Kuogee Hsieh wrote:
>>>> use new introduced dpu_dsc_populate_dsc_config() to calculate
>>>> and populate drm_dsc_info instead of hard code value.
>>>
>>> DPU is an optional component, so DSI driver should not depend on the 
>>> DPU driver.
>>>
>>
>> Today, the implicit dependency is already there. Without the DPU DSC 
>> blocks, the DSI cannot operate in compressed mode.
> 
> It can not operate, but one will compile w/o other driver.
> 

Ack.

>>
>> But, from a SW standpoint I agree we can separate this.
>>
>> We can move this one level up to the disp/ or msm/ folder
>>
>> What do you think about that?
> 
> I think about drivers/gpu/drm/display/drm_dsc_helper.c
> 

No, that wont work because of the explanation given in the prev patch.

>> -- 
> With best wishes
> Dmitry
>