linux-kernel - Re: [PATCH] drm/amdgpu: remove unused variable ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MNxZn+LEOg0L_0+zmMZ52qGCQi-KfMmuD_vSwt8rqJbQ@mail.gmail.com>
Date:   Fri, 24 Feb 2023 17:22:40 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        ruijing.dong@....com, Jane.Jian@....com, James.Zhu@....com,
        tao.zhou1@....com, sonny.jiang@....com, leo.liu@....com,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: remove unused variable ring

Applied.  Thanks!

Alex

On Fri, Feb 24, 2023 at 11:45 AM Tom Rix <trix@...hat.com> wrote:
>
> building with gcc and W=1 reports
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:81:29: error: variable
>   ‘ring’ set but not used [-Werror=unused-but-set-variable]
>    81 |         struct amdgpu_ring *ring;
>       |                             ^~~~
>
> ring is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index 213b43670f23..023a1fffa6a9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -78,12 +78,10 @@ static void vcn_v4_0_set_ras_funcs(struct amdgpu_device *adev);
>  static int vcn_v4_0_early_init(void *handle)
>  {
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
> -       struct amdgpu_ring *ring;
>
>         if (amdgpu_sriov_vf(adev)) {
>                 adev->vcn.harvest_config = VCN_HARVEST_MMSCH;
>                 for (int i = 0; i < adev->vcn.num_vcn_inst; ++i) {
> -                       ring = &adev->vcn.inst[i].ring_enc[0];
>                         if (amdgpu_vcn_is_disabled_vcn(adev, VCN_ENCODE_RING, i)) {
>                                 adev->vcn.harvest_config |= 1 << i;
>                                 dev_info(adev->dev, "VCN%d is disabled by hypervisor\n", i);
> --
> 2.27.0
>