linux-kernel - Re: [PATCH v2 01/29] LoongArch: KVM: Add kvm related header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <004179bf-2d9c-f534-f40a-646bafc1e2bf@loongson.cn>
Date:   Fri, 24 Feb 2023 09:27:31 +0800
From:   Tianrui Zhao <zhaotianrui@...ngson.cn>
To:     Xi Ruoyao <xry111@...111.site>, Paolo Bonzini <pbonzini@...hat.com>
Cc:     Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Mark Brown <broonie@...nel.org>,
        Alex Deucher <alexander.deucher@....com>,
        Oliver Upton <oliver.upton@...ux.dev>, maobibo@...ngson.cn
Subject: Re: [PATCH v2 01/29] LoongArch: KVM: Add kvm related header files



在 2023年02月21日 12:36, Xi Ruoyao 写道:
> On Mon, 2023-02-20 at 14:57 +0800, Tianrui Zhao wrote:
>
> /* snip */
>
>> +/*
>> + * for KVM_GET_FPU and KVM_SET_FPU
>> + */
>> +struct kvm_fpu {
>> +	__u32 fcsr;
>> +	__u32 none;
>> +	__u64 fcc;    /* 8x8 */
>> +	struct kvm_fpureg {
>> +		__u64 val64[4];	//support max 256 bits
>> +	} fpr[32];
> Do we need __attribute__((__aligned__(16))) for fpureg (like
> sc_extcontext in struct sigcontext)?

Thanks,  the loongarch_fpu variable is already has FPU_ALIGN feature in 
the kvm_vcpu_arch structure, so it need not to use __aligned__(16).

Thanks
Tianrui Zhao

>
>> +};
>> +
>> +/*
>> + * For LOONGARCH, we use KVM_SET_ONE_REG and KVM_GET_ONE_REG to
>            ^^^^^^^^^
>            LoongArch

Thanks, I will fix it

Thanks
Tianrui Zhao

>
>> access various
>> + * registers.  The id field is broken down as follows:
>> + *
>> + *  bits[63..52] - As per linux/kvm.h
>> + *  bits[51..32] - Must be zero.
>> + *  bits[31..16] - Register set.