[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXv+5GPWzCsMb3mK7detuBnX8H_FsvbPYTROW1qzkoi8sq0Ng@mail.gmail.com>
Date: Fri, 24 Feb 2023 17:54:05 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: matthias.bgg@...il.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 05/16] arm64: dts: mediatek: mt8183-evb: Couple VGPU
and VSRAM_GPU regulators
On Thu, Feb 23, 2023 at 9:43 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Add coupling for these regulators, as they have a strict voltage output
> relation to satisfy in order to ensure GPU stable operation.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> index 52dc4a50e34d..fd327437e932 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -52,7 +52,6 @@ &auxadc {
>
> &gpu {
> mali-supply = <&mt6358_vgpu_reg>;
> - sram-supply = <&mt6358_vsram_gpu_reg>;
> };
>
> &i2c0 {
> @@ -138,6 +137,16 @@ &mmc1 {
> non-removable;
> };
>
> +&mt6358_vgpu_reg {
> + regulator-coupled-with = <&mt6358_vsram_gpu_reg>;
> + regulator-coupled-max-spread = <100000>;
> +};
> +
> +&mt6358_vsram_gpu_reg {
> + regulator-coupled-with = <&mt6358_vgpu_reg>;
> + regulator-coupled-max-spread = <100000>;
Should we also fix up the constraints?
ChenYu
> +};
> +
> &pio {
> i2c_pins_0: i2c0{
> pins_i2c{
> --
> 2.39.2
>
Powered by blists - more mailing lists