[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d0984638-3f7f-7e4e-fe3e-5e1f88375dca@starfivetech.com>
Date: Fri, 24 Feb 2023 18:14:38 +0800
From: Walker Chen <walker.chen@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
Vinod Koul <vkoul@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor@...nel.org>,
"Palmer Dabbelt" <palmer@...belt.com>,
Emil Renner Berthing <kernel@...il.dk>,
"Emil Renner Berthing" <emil.renner.berthing@...onical.com>
CC: <dmaengine@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: dma: snps,dw-axi-dmac: Add reset
items
On 2023/2/22 17:17, Krzysztof Kozlowski wrote:
> On 21/02/2023 15:04, Walker Chen wrote:
>> This DMA controller needs to be reset before being used on JH7110 SoC,
>> so add reset items to support this chip.
>
> There is reset already. The DMA controller is reset already. Your commit
> msg and commit subject do not match commit at all.
OK, the commit message will be changed to match the actual modification.
>
>>
>> Signed-off-by: Walker Chen <walker.chen@...rfivetech.com>
>> ---
>> .../devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index ad107a4d3b33..c2247c65a22f 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -20,6 +20,7 @@ properties:
>> enum:
>> - snps,axi-dma-1.01a
>> - intel,kmb-axi-dma
>> + - starfive,jh7110-axi-dma
>>
>> reg:
>> minItems: 1
>> @@ -58,7 +59,12 @@ properties:
>> maximum: 8
>>
>> resets:
>> - maxItems: 1
>> + maxItems: 2
>
> This breaks ABI and all other users. Test your changes before sending.
I think 'minItems' should be added here. So like this:
resets:
minItems: 1
maxItems: 2
Other platform/users will not be affected by this.
Thanks.
Best regards,
Walker
Powered by blists - more mailing lists