lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <22aeef5b-99cf-bf98-daa1-8e7cf22dffa7@ghiti.fr>
Date:   Fri, 24 Feb 2023 11:21:16 +0100
From:   Alexandre Ghiti <alex@...ti.fr>
To:     Sia Jee Heng <jeeheng.sia@...rfivetech.com>,
        paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu
Cc:     linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        leyfoon.tan@...rfivetech.com, mason.huo@...rfivetech.com
Subject: Re: [PATCH v4 3/4] RISC-V: mm: Enable huge page support to
 kernel_page_present() function


On 2/21/23 03:35, Sia Jee Heng wrote:
> Currently kernel_page_present() function doesn't support huge page
> detection causes the function to mistakenly return false to the
> hibernation core.
>
> Add huge page detection to the function to solve the problem.
>
> Fixes tag: commit 9e953cda5cdf ("riscv:
> Introduce huge page support for 32/64bit kernel")
>
> Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> Reviewed-by: Mason Huo <mason.huo@...rfivetech.com>
> ---
>   arch/riscv/mm/pageattr.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c
> index 86c56616e5de..ea3d61de065b 100644
> --- a/arch/riscv/mm/pageattr.c
> +++ b/arch/riscv/mm/pageattr.c
> @@ -217,18 +217,26 @@ bool kernel_page_present(struct page *page)
>   	pgd = pgd_offset_k(addr);
>   	if (!pgd_present(*pgd))
>   		return false;
> +	if (pgd_leaf(*pgd))
> +		return true;
>   
>   	p4d = p4d_offset(pgd, addr);
>   	if (!p4d_present(*p4d))
>   		return false;
> +	if (p4d_leaf(*p4d))
> +		return true;
>   
>   	pud = pud_offset(p4d, addr);
>   	if (!pud_present(*pud))
>   		return false;
> +	if (pud_leaf(*pud))
> +		return true;
>   
>   	pmd = pmd_offset(pud, addr);
>   	if (!pmd_present(*pmd))
>   		return false;
> +	if (pmd_leaf(*pmd))
> +		return true;
>   
>   	pte = pte_offset_kernel(pmd, addr);
>   	return pte_present(*pte);


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ