linux-kernel - Re: [PATCH] mailbox: qcom-ipcc: Support multiple channels for a given client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Feb 2023 19:27:39 -0800
From:   Guru Das Srinagesh <quic_gurus@...cinc.com>
To:     Huang Yiwei <quic_hyiwei@...cinc.com>
CC:     <mani@...nel.org>, <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <jassisinghbrar@...il.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_satyap@...cinc.com>, <quic_aiquny@...cinc.com>
Subject: Re: [PATCH] mailbox: qcom-ipcc: Support multiple channels for a
 given client

On Feb 23 2023 14:13, Huang Yiwei wrote:
> Recently a new use case where two signals for the same protocol and
> client is needed, that means there will be more than one channel
> for a mbox node. Current driver only supports one channel, so need
> to remove the limitation and let the driver find every channel
> correctly.
> 
> Signed-off-by: Huang Yiwei <quic_hyiwei@...cinc.com>
> ---
>  drivers/mailbox/qcom-ipcc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
> index 7e27acf6c0cc..367658af089e 100644
> --- a/drivers/mailbox/qcom-ipcc.c
> +++ b/drivers/mailbox/qcom-ipcc.c
> @@ -226,11 +226,9 @@ static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc,
>  		for (j = 0; j < i; j++) {
>  			ret = of_parse_phandle_with_args(client_dn, "mboxes",
>  						"#mbox-cells", j, &curr_ph);
> -			of_node_put(curr_ph.np);
> -			if (!ret && curr_ph.np == controller_dn) {
> +			if (!ret && curr_ph.np == controller_dn)
>  				ipcc->num_chans++;
> -				break;
> -			}
> +			of_node_put(curr_ph.np);

of_node_put can stay where it is - the main change is the removal of the break,
is it not?

Guru Das.