linux-kernel - Re: [PATCH] pinctrl: at91-pio4: fix domain name assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e563ef5d-5e19-3c8c-6880-fa15d232106c@microchip.com>
Date:   Fri, 24 Feb 2023 16:44:01 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <johan+linaro@...nel.org>, <Ludovic.Desroches@...rochip.com>,
        <linus.walleij@...aro.org>
CC:     <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <tglx@...utronix.de>, <maz@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: at91-pio4: fix domain name assignment

On 24.02.2023 15:08, Johan Hovold wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Since commit d59f6617eef0 ("genirq: Allow fwnode to carry name
> information only") an IRQ domain is always given a name during
> allocation (e.g. used for the debugfs entry).
> 
> Drop the no longer valid name assignment, which would lead to an attempt
> to free a string constant when removing the domain on late probe
> failures (e.g. probe deferral).
> 
> Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only")
> Cc: stable@...r.kernel.org      # 4.13
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@...rochip.com> # on SAMA7G5


> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 39b233f73e13..d699588677a5 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -1206,7 +1206,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
>                 dev_err(dev, "can't add the irq domain\n");
>                 return -ENODEV;
>         }
> -       atmel_pioctrl->irq_domain->name = "atmel gpio";
> 
>         for (i = 0; i < atmel_pioctrl->npins; i++) {
>                 int irq = irq_create_mapping(atmel_pioctrl->irq_domain, i);
> --
> 2.39.2
>