linux-kernel - Re: [PATCH v2] staging: rtl8192u: remove split in user-visible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y/naJmGeQKtzgG5h@ubun2204.myguest.virtualbox.org>
Date:   Sat, 25 Feb 2023 15:21:34 +0530
From:   Deepak R Varma <drv@...lo.com>
To:     Леонид Першин 
        <leonid.pershin@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dan Carpenter <error27@...il.com>,
        Tong Zhang <ztong0001@...il.com>,
        Rebecca Mckeever <remckee0@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192u: remove split in user-visible string

On Fri, Feb 24, 2023 at 10:54:22PM +0300, Леонид Першин wrote:
> On Fri, Feb 24, 2023 at 7:58 AM Deepak R Varma <drv@...lo.com> wrote:
> > Hello Leonid,
> > I was not able to trace the v1 of this patch. Did that have a different
> subject?

The line above broke for me in your response. This could be the email editor
issue on your side.

> >
> > Thank you,
> > Deepak.
> 
> Hello Deepak,
> Sorry, I've sent v1 directly to Greg by mistake. Here it is:

No problem. It is important to record such reasons for the reviewer's awareness.
Also, it is a common practice to give credit to the reviewers by mentioning
their name in the  "Change in vx" section.

Good luck.
Deepak.

> 
> On Wed, Feb 22, 2023 at 02:20:29AM +0300, Leonid Pershin wrote:
> > According to coding style, user-visible strings in printk()
> > function calls cannot be split across multiple lines.
> > Issue found with checkpatch.pl.
> >
> > Signed-off-by: Leonid Pershin <leonid.pershin@...il.com>
> > ---
> > Changes in v2:
> >   - Replace printk(KERN_DEBUG...) with pr_debug()
> >
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> > index 9bfd24ad46b6..c378bdff453b 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> > @@ -72,16 +72,14 @@ static void *ieee80211_tkip_init(int key_idx)
> >
> >       priv->tx_tfm_michael = crypto_alloc_shash("michael_mic", 0, 0);
> >       if (IS_ERR(priv->tx_tfm_michael)) {
> > -             printk(KERN_DEBUG "ieee80211_crypt_tkip: could not allocate
> "
> > -                             "crypto API michael_mic\n");
> > +             pr_debug("ieee80211_crypt_tkip: could not allocate crypto
> API michael_mic\n");
> >               priv->tx_tfm_michael = NULL;
> >               goto fail;
> >       }
> >
> >       priv->rx_tfm_michael = crypto_alloc_shash("michael_mic", 0, 0);
> >       if (IS_ERR(priv->rx_tfm_michael)) {
> > -             printk(KERN_DEBUG "ieee80211_crypt_tkip: could not allocate
> "
> > -                             "crypto API michael_mic\n");
> > +             pr_debug("ieee80211_crypt_tkip: could not allocate crypto
> API michael_mic\n");
> >               priv->rx_tfm_michael = NULL;
> >               goto fail;
> >       }
> > --
> > 2.39.2
> >
> 
> Sincerely,
> Leonid