linux-kernel - Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKmqyKPuuHcqYqNinrSfziN1+=5bVTyg=8eZh5j=yYS3BEWMRA@mail.gmail.com>
Date:   Sun, 26 Feb 2023 15:52:19 +1000
From:   Alistair Francis <alistair23@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Alistair Francis <alistair@...stair23.me>, s.hauer@...gutronix.de,
        devicetree@...r.kernel.org, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, arnd@...db.de,
        kernel@...gutronix.de, jernej.skrabec@...il.com,
        linux@...linux.org.uk
Subject: Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815

On Sun, Feb 26, 2023 at 6:37 AM Fabio Estevam <festevam@...il.com> wrote:
>
> On Sat, Feb 25, 2023 at 8:37 AM Alistair Francis <alistair@...stair23.me> wrote:
>
> > +&i2c2 {
> > +       clock-frequency = <100000>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_i2c2>;
> > +       status = "okay";
> > +
> > +       bd71815: pmic@4b {
> > +               compatible = "rohm,bd71815";
> > +               reg = <0x4b>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_bd71815>;
> > +               interrupt-parent = <&gpio6>; /* PMIC_INT_B GPIO6_IO16 */
> > +               interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> > +               gpio-controller;
> > +               clocks = <&clks IMX7D_CLKO2_ROOT_SRC>;
> > +               clock-output-names = "bd71815-32k-out";
> > +               #clock-cells = <0>;
> > +               #gpio-cells = <1>;
>
> The binding document says #gpio-cells = <2>;

Fixed!

>
> > +
> > +               regulators {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       buck1_reg: regulator@0 {
> > +                               reg = <0>;
>
> The regulator@0 and reg should not be present.

Fixed

>
> Please check Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml

Thanks, I double checked my latest code against the bindings.

Alistair