linux-kernel - RE: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR12MB5381DB9F7D91833EA63374CFAFAE9@BN9PR12MB5381.namprd12.prod.outlook.com>
Date:   Sun, 26 Feb 2023 06:37:39 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Darren Hart <dvhart@...radead.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: RE: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of
 depending on it



> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Sunday, 26 February 2023 7:40
> To: linux-kernel@...r.kernel.org
> Cc: Randy Dunlap <rdunlap@...radead.org>; Vadim Pasternak
> <vadimp@...lanox.com>; Darren Hart <dvhart@...radead.org>; Hans de
> Goede <hdegoede@...hat.com>; Mark Gross <markgross@...nel.org>;
> platform-driver-x86@...r.kernel.org
> Subject: [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead
> of depending on it
> 
> REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru
> "make *config", so drivers should select it instead of depending on it if they
> need it.
> 
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
> 
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
> 
> Fixes: ef0f62264b2a ("platform/x86: mlx-platform: Add physical bus number
> auto detection")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Acked-by: Vadim Pasternak <vadimp@...dia.com>

> Cc: Vadim Pasternak <vadimp@...lanox.com>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Mark Gross <markgross@...nel.org>
> Cc: platform-driver-x86@...r.kernel.org
> ---
>  drivers/platform/x86/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -- a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -955,7 +955,8 @@ config SERIAL_MULTI_INSTANTIATE
> 
>  config MLX_PLATFORM
>  	tristate "Mellanox Technologies platform support"
> -	depends on I2C && REGMAP
> +	depends on I2C
> +	select REGMAP
>  	help
>  	  This option enables system support for the Mellanox Technologies
>  	  platform. The Mellanox systems provide data center networking