[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d6e3ec43-895c-6768-14cf-6ebd1fd83d65@linaro.org>
Date: Sun, 26 Feb 2023 23:14:19 +0100
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Nick Alcock <nick.alcock@...cle.com>, mcgrof@...nel.org
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
Rafał Miłecki <zajec5@...il.com>,
linux-mips@...r.kernel.org
Subject: Re: [PATCH 07/27] kbuild, MIPS: BCM47XX: remove MODULE_LICENSE in
non-modules
On 22/2/23 13:14, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: "Rafał Miłecki" <zajec5@...il.com>
> Cc: linux-mips@...r.kernel.org
> ---
> drivers/firmware/broadcom/bcm47xx_nvram.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>
Powered by blists - more mailing lists