linux-kernel - Re: [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Feb 2023 15:49:27 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     minyard@....org
Cc:     linux-kernel@...r.kernel.org, Andrew Jeffery <andrew@...id.au>,
        openipmi-developer@...ts.sourceforge.net,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead
 of depending on it



On 2/26/23 14:59, Corey Minyard wrote:
> On Sat, Feb 25, 2023 at 09:39:46PM -0800, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> Therefore, change the use of "depends on REGMAP_MMIO" to
>> "select REGMAP_MMIO", which will also set REGMAP.
> 
> This seems reasonable.  I can take it into my tree, or..

Just take it, please. I expect that each subsystem maintainer
will take their respective patches.

> Acked-by: Corey Minyard <cminyard@...sta.com>
> 
>>
>> Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Andrew Jeffery <andrew@...id.au>
>> Cc: Corey Minyard <minyard@....org>
>> Cc: openipmi-developer@...ts.sourceforge.net
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>>  drivers/char/ipmi/Kconfig |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
>> --- a/drivers/char/ipmi/Kconfig
>> +++ b/drivers/char/ipmi/Kconfig
>> @@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO
>>  
>>  config ASPEED_BT_IPMI_BMC
>>  	depends on ARCH_ASPEED || COMPILE_TEST
>> -	depends on REGMAP && REGMAP_MMIO && MFD_SYSCON
>> +	depends on MFD_SYSCON
>> +	select REGMAP_MMIO
>>  	tristate "BT IPMI bmc driver"
>>  	help
>>  	  Provides a driver for the BT (Block Transfer) IPMI interface

-- 
~Randy